[Buildroot] [PATCH 2/2] configs/nezha_defconfig: new defconfig

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Nov 5 13:10:42 UTC 2021


Howdy,

Thanks for this! It's obviously great, just a couple of nits, see below.

On Fri,  5 Nov 2021 13:38:47 +0100
Peter Korsgaard <peter at korsgaard.com> wrote:

> diff --git a/board/nezha/post-build.sh b/board/nezha/post-build.sh
> new file mode 100755
> index 0000000000..9d38b13b84
> --- /dev/null
> +++ b/board/nezha/post-build.sh
> @@ -0,0 +1,6 @@
> +#!/bin/sh
> +BOARD_DIR=$(dirname $0)
> +
> +# Bring the extlinux.conf file in
> +install -D -m 0644 ${BOARD_DIR}/extlinux.conf \
> +	${TARGET_DIR}/boot/extlinux/extlinux.conf

Probably you don't even need a post-build script here, the
extlinux.conf could just be added to the rootfs using a rootfs overlay.


> new file mode 100644
> index 0000000000..f04404b9a4
> --- /dev/null
> +++ b/configs/nezha_defconfig
> @@ -0,0 +1,36 @@
> +BR2_riscv=y
> +BR2_GLOBAL_PATCH_DIR="board/nezha/patches"
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_14=y
> +BR2_ROOTFS_POST_BUILD_SCRIPT="board/nezha/post-build.sh"
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/nezha/genimage.cfg"
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_GIT=y
> +BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/smaeul/linux.git"
> +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="012f5a3d01be6d44e32c74bb3637ec281790b297"

Here...


> +BR2_TARGET_OPENSBI=y
> +BR2_TARGET_OPENSBI_CUSTOM_GIT=y
> +BR2_TARGET_OPENSBI_CUSTOM_REPO_URL="https://github.com/smaeul/opensbi"
> +BR2_TARGET_OPENSBI_CUSTOM_REPO_VERSION="b9125c6f8909d1cc0417795737fc13cb6297ff11"

Here...

> +BR2_TARGET_UBOOT_CUSTOM_GIT=y
> +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/smaeul/u-boot"
> +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="62392d3b8a624a80646c1876533336f90140088d"

.. and here

We normally use the github macro to download a tarball instead of a
full Git repository.

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com



More information about the buildroot mailing list