[Buildroot] [PATCH 1/1] utils/checkpackagelib/lib_mk.py: check DEPENDENCIES
Fabrice Fontaine
fontaine.fabrice at gmail.com
Wed Nov 10 17:52:18 UTC 2021
Check that {FOO}_DEPENDENCIES are never overriden in a conditional
Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
---
utils/checkpackagelib/lib_mk.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py
index 0278354434..d09922f724 100644
--- a/utils/checkpackagelib/lib_mk.py
+++ b/utils/checkpackagelib/lib_mk.py
@@ -88,6 +88,8 @@ class OverriddenVariable(_CheckFunction):
r"_SITE\s*=\s*",
r"_SOURCE\s*=\s*",
r"_VERSION\s*=\s*"])))
+ FORBIDDEN_OVERRIDDEN = re.compile(r"^[A-Z0-9_]+({})".format("|".join([
+ r"_DEPENDENCIES\s*=\s*"])))
def before(self):
self.conditional = 0
@@ -123,6 +125,10 @@ class OverriddenVariable(_CheckFunction):
.format(self.filename, lineno, variable),
text]
else:
+ if self.FORBIDDEN_OVERRIDDEN.search(text):
+ return ["{}:{}: conditional override of variable {}"
+ .format(self.filename, lineno, variable),
+ text]
if variable not in self.unconditionally_set:
self.conditionally_set.append(variable)
return
--
2.33.0
More information about the buildroot
mailing list