[Buildroot] [PATCH v1 2/3] package/libtomcrypt: compile with -fPIC to enable linking to dynamic libraries/exectuables

[Arnout Vandecappelle]

On 12/04/2021 21:55, Peter Seiderer wrote:
> Fixes:
> 
>   .../x86_64-buildroot-linux-gnu/bin/ld: .../host/x86_64-buildroot-linux-gnu/sysroot/usr/lib/libtomcrypt.a(md5.o): relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a shared object; recompile with -fPIC
> 
> Signed-off-by: Peter Seiderer <ps.report at gmx.net>
> ---
>  package/libtomcrypt/libtomcrypt.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libtomcrypt/libtomcrypt.mk b/package/libtomcrypt/libtomcrypt.mk
> index fa6dde64cd..b6ad77daec 100644
> --- a/package/libtomcrypt/libtomcrypt.mk
> +++ b/package/libtomcrypt/libtomcrypt.mk
> @@ -17,7 +17,7 @@ LIBTOMCRYPT_DEPENDENCIES = libtommath
>  # 0001-fix-CVE-2019-17362.patch
>  LIBTOMCRYPT_IGNORE_CVES += CVE-2019-17362
>  
> -LIBTOMCRYPT_CFLAGS = -I./src/headers $(TARGET_CFLAGS) -DLTC_SOURCE -DLTM_DESC
> +LIBTOMCRYPT_CFLAGS = -I./src/headers $(TARGET_CFLAGS) -fPIC -DLTC_SOURCE -DLTM_DESC

 On some architectures, -fPIC is incompatible with static builds. So this should
probably only be done in non-static builds.

 Marked as Changes Requested.

 Regards,
 Arnout

>  
>  define LIBTOMCRYPT_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(LIBTOMCRYPT_CFLAGS)"
>