[Buildroot] [PATCH] support/scripts/pkg-stats: properly handle host packages with -c option
Arnout Vandecappelle
arnout at mind.be
Mon Jan 11 21:25:53 UTC 2021
On 08/01/2021 22:37, Yann E. MORIN wrote:
> Thomas, All,
>
> On 2021-01-07 22:34 +0100, Thomas Petazzoni spake thusly:
>> On Thu, 7 Jan 2021 22:32:07 +0100
>> "Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:
>>
>>> I think the correct fix would be for the json output to already contain
>>> the base name of the package, and the script to use that field, rather
>>> than the key, as a package name. That way, the behaviour would be the
>>> same for both target and host packages.
>>
>> Right, that could certainly work as well.
>>
>>>
>>> Something like:
>>>
>>> diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
>>> index a2cc160d0b..0f9d612f12 100644
>>> --- a/package/pkg-utils.mk
>>> +++ b/package/pkg-utils.mk
>>> @@ -91,6 +91,7 @@ endef
>>> # $(1): upper-case package or filesystem name
>>> define json-info
>>> "$($(1)_NAME)": {
>>> + "name": "$($(1)_RAWNAME)",
>>
>> "name" or "rawname" ?
>
> "rawname" is a detail of the naming of our internal variables. WE do not
> want to propagate that to the outside world.
>
> "name" is really that: the name of the package, by which people know it
> and talk about.
+1
Regards,
Arnout
More information about the buildroot
mailing list