[Buildroot] [PATCH v2 2/2] package/makedevs: coding style and whitespace cleanup

Joachim Wiberg troglobit at gmail.com
Thu Dec 23 08:53:04 UTC 2021


On 12/22/21 9:24 PM, Arnout Vandecappelle wrote:
> On 22/12/2021 20:32, Joachim Wiberg wrote:
>> On 12/22/21 3:12 PM, Arnout Vandecappelle wrote:
>>> Although I'm OK with the changes per se, I general I don't believe much
>>> in manually maintained coding style. So I'd propose to at least include
>>> a .clang-format file in the top level directory that defines our coding
>>> style. We wouldn't enforce it with CI or anything (at least, not for the
>>> time being), but at least it makes it easy to apply the coding style and
>>> to know that it's correct.
>> We don't seem to have any .clang-format file at the moment, so if I copy
>> the latest version from kernel.org, where in the tree should it live?
>  At the top level, so clang-format and editors find it out of the box.

Apologies, I see now you wrote that already in your original reply, but
it seems my eyes failed me.

I'm compiling a v3 of my patch set now, which includes the .clang-format
as a separate commit.  I expect there may be some discussion regarding
max line lengths and such, but hopefully it won't be too controversial.

Best regards
 /Joachim




More information about the buildroot mailing list