[Buildroot] [PATCH v2 2/2] package/makedevs: coding style and whitespace cleanup
Joachim Wiberg
troglobit at gmail.com
Wed Dec 22 19:32:43 UTC 2021
On 12/22/21 3:12 PM, Arnout Vandecappelle wrote:
> On 22/12/2021 09:35, Joachim Wiberg wrote:
>> This patch is a modest attempt to clean up the coding style and fix
>> some whitespace issues. Some changes, e.g., comments are for
>> consistency with the rest for the program.
> Although I'm OK with the changes per se, I general I don't believe much
> in manually maintained coding style. So I'd propose to at least include
> a .clang-format file in the top level directory that defines our coding
> style. We wouldn't enforce it with CI or anything (at least, not for the
> time being), but at least it makes it easy to apply the coding style and
> to know that it's correct.
OK, that's a little bit more than I bargained for. Just wanted to clean
it up a bit while I was in that part of the tree. But I'll give it a
go, it's Christmas (and DEC 22!!) after all :-)
We don't seem to have any .clang-format file at the moment, so if I copy
the latest version from kernel.org, where in the tree should it live?
I'm thinking we might want to reuse it for other in-tree tools, maybe
support/misc/, or perhaps each package should supply its own?
> As to which coding style: something close to kernel is preferred.
Suspected as much, thanks!
Best regards
/Joachim
More information about the buildroot
mailing list