[Buildroot] [PATCH v2] board/olimex/stmp1_olinuxino: add STMP157-OLinuXino-LIME2 board support

[Thomas Petazzoni]

Hello François,

On Sat, 11 Dec 2021 09:09:49 +0100
Francois Perrad <fperrad at gmail.com> wrote:

> kernel:
> - the device tree is not yet mainline
> - ITE IT66121 (HDMI) is mainline only since 5.14
> 
> u-boot:
> - the device tree is not yet mainline
> - this board uses AXP209 as PMIC instead of the STPMIC1,
>   this use case of AXP209 is not mainline
> 
> arm-trusted-firmware:
> at this time, there is no patch for this board,
> so u-boot-spl is used as FSBL (basic boot chain)

Could we use the code from the Olimex Github repos instead? Your commit
really adds two many large board-specific patches. We try hard to avoid
this kind of stuff in Buildroot.

Also, I think the kernel config file shouldn't have comments. We pretty
much never do that with kernel configuration files as it's too annoying
to maintain.

Finally, your SoB line is missing.

Could you rework this?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com