[Buildroot] [PATCH v2 1/1] configs/stm32mp157c_odyssey: new defconfig
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Aug 1 21:19:23 UTC 2021
Simon, All,
On 2021-08-01 22:02 +0200, Yann E. MORIN spake thusly:
> On 2021-07-30 07:56 +0000, dopsi at dopsi.ch spake thusly:
> > From: Simon Doppler <dopsi at dopsi.ch>
> > STM32MP157C-Odyssey reference:
> > https://wiki.seeedstudio.com/ODYSSEY-STM32MP157C/
[--SNIP--]
> > +++ b/board/seeed/stm32mp157c-odyssey/overlay/boot/extlinux/extlinux.conf
> > @@ -0,0 +1,4 @@
> > +label stm32mp157c-odyssey-buildroot
> > + kernel /boot/zImage
> > + devicetree /boot/stm32mp157c-odyssey.dtb
> > + append root=/dev/mmcblk0p4 rootwait
> What is this extlinux.conf file for? As far as I can see, this defconfig
> does not use syslinux, which is anyway only available on x86 and x86_64.
Breaking News! U-Boot can read the extlinux.conf format! More at 10!
I was not aware of that, so disregard this comment of mione, sorry.
Regards,
Yann E. MORIN.
> > diff --git a/board/seeed/stm32mp157c-odyssey/patches/linux/5.10.1/0001-sdmmc1-broken-cd.patch b/board/seeed/stm32mp157c-odyssey/patches/linux/5.10.1/0001-sdmmc1-broken-cd.patch
> > new file mode 100644
> > index 0000000000..6f266706a4
> > --- /dev/null
> > +++ b/board/seeed/stm32mp157c-odyssey/patches/linux/5.10.1/0001-sdmmc1-broken-cd.patch
> > @@ -0,0 +1,15 @@
> > +linux: stm32mp157c-odyssey.dts: remove the SDMMC1 CD as per schematic
> > +
> > +Signed-off-by: Simon Doppler <dopsi at dopsi.ch>
> > +
> > +--- linux-5.10.1.orig/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> > ++++ linux-5.10.1/arch/arm/boot/dts/stm32mp157c-odyssey.dts
> > +@@ -64,7 +64,7 @@
> > + pinctrl-0 = <&sdmmc1_b4_pins_a>;
> > + pinctrl-1 = <&sdmmc1_b4_od_pins_a>;
> > + pinctrl-2 = <&sdmmc1_b4_sleep_pins_a>;
> > +- cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> > ++ broken-cd;
>
> Would it not be better to backport upstream commit 0171b07373cc (ARM:
> dts: stm32: fix stm32mp157c-odyssey card detect pin):
>
> - cd-gpios = <&gpiob 7 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> + cd-gpios = <&gpioi 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
>
> Except for those two minor nits, this v2 looks OK.
>
> Regards,
> Yann E. MORIN.
>
> > + disable-wp;
> > + st,neg-edge;
> > + bus-width = <4>;
> > diff --git a/configs/stm32mp157c_odyssey_defconfig b/configs/stm32mp157c_odyssey_defconfig
> > new file mode 100644
> > index 0000000000..078ff74923
> > --- /dev/null
> > +++ b/configs/stm32mp157c_odyssey_defconfig
> > @@ -0,0 +1,31 @@
> > +BR2_arm=y
> > +BR2_cortex_a7=y
> > +BR2_GLOBAL_PATCH_DIR="board/seeed/stm32mp157c-odyssey/patches"
> > +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y
> > +BR2_ROOTFS_OVERLAY="board/seeed/stm32mp157c-odyssey/overlay/"
> > +BR2_ROOTFS_POST_IMAGE_SCRIPT="support/scripts/genimage.sh"
> > +BR2_ROOTFS_POST_SCRIPT_ARGS="-c board/seeed/stm32mp157c-odyssey/genimage.cfg"
> > +BR2_LINUX_KERNEL=y
> > +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> > +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.10.1"
> > +BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> > +BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/seeed/stm32mp157c-odyssey/linux.config"
> > +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> > +BR2_LINUX_KERNEL_INTREE_DTS_NAME="stm32mp157c-odyssey"
> > +BR2_LINUX_KERNEL_INSTALL_TARGET=y
> > +BR2_TARGET_ROOTFS_EXT2=y
> > +BR2_TARGET_ROOTFS_EXT2_4=y
> > +BR2_TARGET_ROOTFS_EXT2_SIZE="120M"
> > +# BR2_TARGET_ROOTFS_TAR is not set
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE=y
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_PLATFORM="stm32mp1"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_ADDITIONAL_VARIABLES="STM32MP_SDMMC=1 AARCH32_SP=sp_min DTB_FILE_NAME=stm32mp157c-odyssey.dtb"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES="*.stm32"
> > +BR2_TARGET_ARM_TRUSTED_FIRMWARE_NEEDS_DTC=y
> > +BR2_TARGET_UBOOT=y
> > +BR2_TARGET_UBOOT_BOARD_DEFCONFIG="stm32mp15_trusted"
> > +BR2_TARGET_UBOOT_NEEDS_DTC=y
> > +# BR2_TARGET_UBOOT_FORMAT_BIN is not set
> > +BR2_TARGET_UBOOT_FORMAT_STM32=y
> > +BR2_TARGET_UBOOT_CUSTOM_MAKEOPTS="DEVICE_TREE=stm32mp157c-odyssey"
> > +BR2_PACKAGE_HOST_GENIMAGE=y
> > --
> > 2.30.2
> >
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list