[Buildroot] [RFC v1 12/13] package/gstreamer1-editing-services: bump version to 1.18.0 and convert to meson
Peter Seiderer
ps.report at gmx.net
Thu Sep 24 20:23:40 UTC 2020
Hello Thomas,
On Wed, 23 Sep 2020 22:30:20 +0200, Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote:
> On Wed, 16 Sep 2020 21:49:32 +0200
> Peter Seiderer <ps.report at gmx.net> wrote:
>
> > +ifeq ($(BR2_PACKAGE_GST1_VALIDATE),y)
>
> You just dropped this option and the corresponding package in PATCH
> 08/13 of this series, so this cannot be good.
Your are right..., will be fixed in v2....
>
> > +GSTREAMER1_EDITING_SERVICES_DEPENDENCIES += gst1-validate
> > +GSTREAMER1_EDITING_SERVICES_CONF_OPTS += -Dvalidate=enabled
> > +else
> > +GSTREAMER1_EDITING_SERVICES_CONF_OPTS += -Dvalidate=disabled
> > +endif
> >
> > # examples need GTK2/3 with X11 backend
> > ifneq ($(BR2_PACKAGE_LIBGTK2)$(BR2_PACKAGE_LIBGTK3_X11),)
> > -GSTREAMER1_EDITING_SERVICES_CONF_OPTS += --enable-examples
> > +GSTREAMER1_EDITING_SERVICES_CONF_OPTS += -Dexamples=enabled
> >
> > ifeq ($(BR2_PACKAGE_LIBGTK2),y)
> > -GSTREAMER1_EDITING_SERVICES_CONF_OPTS += --with-gtk=2.0
> > +# ToDo: meson.build states 'TODO Properly port to Gtk 3'
> > +# ToDo: examples/c/ges-ui.glade states 'requires lib="gtk+" version="2.16"'
> > +# GSTREAMER1_EDITING_SERVICES_CONF_OPTS += --with-gtk=2.0
>
> And so ?
From streamer1-editing-services-1.18.0/examples/c/meson.build
# TODO Properly port to Gtk 3
#
# if gtk_dep.found()
# examples = examples + ['ges-ui']
# endif
So, the only example needing gtk is skipped for this version...
But thinking a little about, I would prefer to disable the
example support at whole...
Regards,
Peter
>
> > GSTREAMER1_EDITING_SERVICES_DEPENDENCIES += libgtk2
> > else
> > -GSTREAMER1_EDITING_SERVICES_CONF_OPTS += --with-gtk=3.0
> > +# ToDo: meson.build states 'TODO Properly port to Gtk 3'
> > +# ToDo: examples/c/ges-ui.glade states 'requires lib="gtk+" version="2.16"'
> > +# GSTREAMER1_EDITING_SERVICES_CONF_OPTS += --with-gtk=3.0
>
> And so ?
>
> > GSTREAMER1_EDITING_SERVICES_DEPENDENCIES += libgtk3
> > endif
>
> Thanks!
>
> Thomas
More information about the buildroot
mailing list