[Buildroot] [PATCH/next 2/2] package/rhash: add host variant
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Sat Nov 7 13:10:13 UTC 2020
On Fri, 6 Nov 2020 21:26:32 +0100
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:
> + --extra-ldflags="$(HOST_LDFLAGS) -L $(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib" \
Well, HOST_LDFLAGS precisely contains
-L$(HOST_DIR)/lib -Wl,-rpath,$(HOST_DIR)/lib
So this feels a bit redundant with what you're doing. Am I missing
something ?
> $(eval $(generic-package))
> +$(eval $(host-autotools-package))
If the target variant if a generic-package, the host variant should
also be a host-generic-package.
Also, in general we don't really like to have "orphan" host packages.
Shouldn't this host package be added together with the support for sha3
hashes ?
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list