[Buildroot] [PATCH 1/3] Makefile: don't hang the build if there are no file lists

Thomas Petazzoni thomas.petazzoni at bootlin.com
Fri Mar 20 21:10:26 UTC 2020


On Wed, 18 Mar 2020 22:49:08 +0100
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:

> I would like to suggest an alternative, that guarantees the files are
> created, even if empty:
> 
>     $(if $(STAGING_DIR_FILES_LISTS), \
>         cat $(STAGING_DIR_FILES_LISTS)) >$(BUILD_DIR)/packages-file-list-staging.txt
> 
> Notice how the redirection is outside the conditional, so that if there
> is no file, the commadn will be:
> 
>     > $(BUILD_DIR)/packages-file-list-staging.txt  
> 
> Which will create an empty file.
> 
> Thoughts? Shall I do that when applying the series or will you want to
> respin?

What you suggest sounds good to me. Feel free to tweak that when
applying. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list