[Buildroot] [PATCH 1/1] package/rtty: fix build with mbedtls but without zlib

[Thomas Petazzoni]

On Sun, 30 Aug 2020 22:39:43 +0200
Fabrice Fontaine <fontaine.fabrice at gmail.com> wrote:

> The suggested patch is only fixing a build failure when zlib is not found.
> We're already linking needlessly with zlib since the bump to version
> 7.1.4 with commit 0c80245ddbe78c8e443f98b9bbccac56331cdb26.
> So would you advise that I revert
> https://github.com/zhaojh329/rtty/commit/7b8efe11dbafce97971dc130bf6cc1756f34ce07
> and manually link with -lz in rtty.mk if
> BR2_PACKAGE_MBEDTLS_COMPRESSION is set?

The only sane way to fix this is to use pkg-config, but as you said
mbedtls apparently doesn't provide any .pc file.

So I'd say, leave it as it is, but it's better to have the full
explanation on the benefits/drawbacks in the commit log rather than
having to second guess it.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com