[Buildroot] [PATCH] boot/uboot: add option to define custom dependencies

Thomas Petazzoni thomas.petazzoni at bootlin.com
Mon Apr 27 19:08:49 UTC 2020


On Mon, 27 Apr 2020 20:19:45 +0200
Heiko Stuebner <heiko.stuebner at theobroma-systems.com> wrote:

> Am Montag, 27. April 2020, 18:59:51 CEST schrieb Arnout Vandecappelle:
> > On 27/04/2020 17:41, Thomas Petazzoni wrote:  
> > > Thanks. Should I nevertheless introduce the PYLIBFDT_PYTHON3 and
> > > PYELFTOOLS_PYTHON3 options, in addition to this ? Or do we for these
> > > new use cases favor using only the CUSTOM_DEPENDENCIES solution ?  
> > 
> >  Given how controversial this new option is, I guess it's better to add the
> > -python3 options.  
> 
> personally I imagined CUSTOM_DEPENDENCIES to _not_ be preferred
> over standard options.

Indeed, they are not necessarily mutually exclusive.

> I.e. things like BR2_TARGET_UBOOT_NEEDS_ATF_BL31 come with their
> own special handling for example for including the bl31 binary into the
> build.

NEEDS_ATF_BL31 indeed does more than adding dependencies. But:

ifeq ($(BR2_TARGET_UBOOT_NEEDS_DTC),y)
UBOOT_DEPENDENCIES += host-dtc
endif

ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYLIBFDT),y)
UBOOT_DEPENDENCIES += host-python host-swig
endif

ifeq ($(BR2_TARGET_UBOOT_NEEDS_PYELFTOOLS),y)
UBOOT_DEPENDENCIES += host-python-pyelftools
endif

ifeq ($(BR2_TARGET_UBOOT_NEEDS_OPENSSL),y)
UBOOT_DEPENDENCIES += host-openssl
endif

ifeq ($(BR2_TARGET_UBOOT_NEEDS_LZOP),y)
UBOOT_DEPENDENCIES += host-lzop
endif

is really all about adding dependencies, and we need two more.

But OK, I'll cook a patch to support the Python 3.x situation.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list