[Buildroot] [PATCH 1/1] mbuffer: new package

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Apr 12 20:42:57 UTC 2020


Hello Mircea,

On Tue, 11 Feb 2020 15:46:52 +0200
Mircea Gliga <gliga.mircea at gmail.com> wrote:

> Signed-off-by: Mircea Gliga <gliga.mircea at gmail.com>

Sorry for the long delay. I have now applied your patch, with a few
changes.

First, I changed the commit title to "package/mbuffer: new package", to
follow our convention.

>  package/Config.in            |  1 +
>  package/mbuffer/Config.in    |  8 ++++++++
>  package/mbuffer/mbuffer.hash |  5 +++++
>  package/mbuffer/mbuffer.mk   | 19 +++++++++++++++++++

I've added an entry for this package in the DEVELOPERS file.

> diff --git a/package/mbuffer/Config.in b/package/mbuffer/Config.in
> new file mode 100644
> index 0000000000..5c733c0ec5
> --- /dev/null
> +++ b/package/mbuffer/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_MBUFFER
> +	bool "mbuffer"
> +	depends on !BR2_STATIC_LIBS

I've added a comment that explains why we have this dependency:

	depends on !BR2_STATIC_LIBS # dlopen()

> +	help
> +	  mbuffer is a tool for buffering data streams with a large set
> +	  of unique features.
> +
> +	  http://www.maier-komor.de/mbuffer.html

And here I've added a Config.in comment that shows up in
BR2_STATIC_LIBS configurations, so that users now why mbuffer is not
available.

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list