[Buildroot] [PATCH] package/jitterentropy-library: fix build failure due to missing -fPIC

Peter Korsgaard peter at korsgaard.com
Fri Oct 25 16:19:55 UTC 2019


>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:

Hi,

 >> +
 >> define JITTERENTROPY_LIBRARY_BUILD_CMDS
 >> -	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS)
 >> +	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) $(TARGET_CONFIGURE_OPTS) CFLAGS="$(JITTERENTROPY_LIBRARY_CFLAGS)"

 >  And here we see the actual issue: TARGET_CONFIGURE_OPTS should be passed in the
 > environment instead of as arguments, so the Makefile can add its stuff to it.

 >  Hm, but maybe there are indeed good reasons to override the CFLAGS, because the
 > fstack-protector-all requires support from the toolchain. On the other hand, we
 > probably *do* want to keep the -O0 and -fwrapv flags...

The fstack-protector-* options should be handled by BR2_SSP_* and
hardcoded in the package. Why would we want to use -O0?

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list