[Buildroot] [PATCH 1/1] package/libva: fix mesa3d glx support

[Thomas Petazzoni]

On Tue,  1 Oct 2019 08:05:20 +0200
Bernd Kuhls <bernd.kuhls at t-online.de> wrote:

> https://git.buildroot.net/buildroot/commit/package/mesa3d?id=5cb821d5635626b7327d5d704555c412e5ed5a1f
> 
> added a new option to enable GLX support.
> 
> This patch adjusts libva to use the new logic.
> 
> Fixes:
> http://autobuild.buildroot.net/results/797/79776104e681402c24160be15789fe67bb69f833/
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>

Applied, thanks. However, I have a comment below.

> ---
>  package/libva/libva.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/libva/libva.mk b/package/libva/libva.mk
> index 7bf1839f4c..6c8243da90 100644
> --- a/package/libva/libva.mk
> +++ b/package/libva/libva.mk
> @@ -20,7 +20,7 @@ LIBVA_CONF_OPTS = \
>  ifeq ($(BR2_PACKAGE_XORG7),y)
>  LIBVA_DEPENDENCIES += xlib_libX11 xlib_libXext xlib_libXfixes
>  LIBVA_CONF_OPTS += --enable-x11
> -ifeq ($(BR2_PACKAGE_MESA3D_DRI_DRIVER),y)
> +ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_GLX),y)
>  LIBVA_DEPENDENCIES += mesa3d

I think that depending on mesa3d and a mesa3d-specific option is
probably not correct. Indeed, a different OpenGL implementation than
Mesa3D can provide OpenGL GLX. For example, the nvidia-driver and
amd-catalyst drivers I believe also provide OpenGL GLX.

That's clearly not an issue with your patch, as it was already not
correct. But it might be nice to fix this at some point.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com