[Buildroot] [PATCH 1/1] package/libnfc: support pcsc-lite
Thomas Petazzoni
thomas.petazzoni at bootlin.com
Mon May 27 09:15:50 UTC 2019
Hello,
On Mon, 27 May 2019 10:27:03 +0200
Raul Hidalgo Caballero <deinok at deinok.com> wrote:
>
Here as well: please send with git send-email so that we can do a
proper review.
A few comments though:
- We need you to use your real name as the patch author and for the
Signed-off-by line
- Why are you making pcsc-lite a mandatory dependency of libnfc ?
Since libnfc builds fine today with pcsc-lite, it means it should be
an optional dependency. Either add a sub-option to enable the
different libnfc drivers, or automatically add pcsc-lite to the
dependencies if BR2_PACKAGE_PCSC_LITE=y.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
More information about the buildroot
mailing list