[Buildroot] [PATCH] package/netsurf: disallow on archs requiring ABI specific CFLAGS

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at bootlin.com> writes:

 > Hello,
 > On Fri, 31 May 2019 23:40:52 +0200
 > Peter Korsgaard <peter at korsgaard.com> wrote:

 >> Fixes:
 >> http://autobuild.buildroot.net/results/67ef520d82ea529a9fe593d83a3aeae5f8b0ee5d/
 >> http://autobuild.buildroot.net/results/eafc3e4be571d5ecee549a11530ac4e508f31782/
 >> http://autobuild.buildroot.net/results/ba7f30833fef54162a82f4b336a72d6599594526/
 >> 
 >> The netsurf build system mixes up host and target CFLAGS, so it isn't
 >> compatible with architectures where we pass ABI specicif compiler flags (in
 >> TARGET_ABI).
 >> 
 >> Add a _ARCH_SUPPORTS kconfig variable matching the TARGET_ABI logic we have
 >> in package/Makefile.in, and use it to disallow netsurf for those
 >> architectures.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter at korsgaard.com>

 > I understand the idea, but we need to realize it has some drawbacks:

 >  - If we add additional flags for some architecture, this will have to
 >    be updated.

Correct, but the autobuilders will presumably show us pretty fast.


 >  - If some custom flags are passed in BR2_TARGET_OPTIMIZATION, I would
 >    assume it would also cause a build failure, no ?

Yes - If they are ABI specific, E.G. not understood by the host compiler.


 > If we really can't remove the package, then I'm fine with this patch as
 > a stop-gap measure. But I think removing the package is the sanest
 > thing to do. If anything, removing the package might wake up the people
 > using it so that they fix it.

I agree, I only created this patch as there was pushback on IRC against
removing netsurf this close to the release.

I'll apply this for master and then revisit the removal once we have next
merged.

-- 
Bye, Peter Korsgaard