[Buildroot] [PATCH] support/scripts/apply-patches: use "git apply" as a fallback when applying patches
Peter Korsgaard
peter at korsgaard.com
Wed Jan 23 20:34:00 UTC 2019
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
Hi,
>> With this patch a package selection change that works on the developer's
>> machine where git is installed, would fail on the production build
>> machine that is missing git. Is there a clear error message in case of
>> patch failure?
> I'm with Baruch here. The reason to have this feature is exactly to have the
> possibility to have patches that modify binaries or that modify symlinks. Thus,
> it becomes likely that someone will submit such a patch. It will work for the
> developer, and it will also work in the autobuilders since all of them have git
> installed (otherwise they wouldn't be able to clone the Buildroot repo). Thus,
> any such patch will go unnoticed.
I agree, that is not good.
> I don't think it hurts to force git as a dependency.
If we do that, should we then always use git apply instead of patch?
(and drop the patch dependency)
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list