[Buildroot] [PATCH 1/1] Provides puredata package

[Matthew Weber]

Mitchell,

On Mon, Jan 7, 2019 at 9:49 PM Mitchell Dokken
<mitchell.dokken at gmail.com> wrote:
>
> Signed-off-by: Mitchell Dokken <Mitchell.Dokken at gmail.com>
> ---
>  package/Config.in              |  1 +
>  package/puredata/Config.in     | 12 ++++++++++++
>  package/puredata/puredata.hash |  2 ++
>  package/puredata/puredata.mk   | 34 ++++++++++++++++++++++++++++++++++

If you're up for maintaining this package, I'd suggest adding yourself
to the DEVELOPERS file.  Then you'll get emails if the build fails
when the autobuilder is testing different build configurations.

>  4 files changed, 49 insertions(+)
>  create mode 100644 package/puredata/Config.in
>  create mode 100644 package/puredata/puredata.hash
>  create mode 100644 package/puredata/puredata.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 0df9b73088..e029de53db 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -45,6 +45,7 @@ menu "Audio and video applications"
>         source "package/on2-8170-libs/Config.in"
>         source "package/opus-tools/Config.in"
>         source "package/pulseaudio/Config.in"
> +       source "package/puredata/Config.in"
>         source "package/sox/Config.in"
>         source "package/squeezelite/Config.in"
>         source "package/tovid/Config.in"
> diff --git a/package/puredata/Config.in b/package/puredata/Config.in
> new file mode 100644
> index 0000000000..c8bafe8885
> --- /dev/null
> +++ b/package/puredata/Config.in
> @@ -0,0 +1,12 @@
> +config BR2_PACKAGE_PUREDATA
> +       bool "puredata"
> +       select BR2_PACKAGE_TK
> +       select BR2_PACKAGE_TCL
> +       select BR2_PACKAGE_ALSA_LIB
> +       select BR2_PACKAGE_ALSA_UTILS
> +       select BR2_PACKAGE_XORG7
> +       select BR2_PACKAGE_XAPP_XAUTH

Each of these selects won't automatically assume the respective
"depends on" found in some of those package's Config.in.  Please
reflect those "depends on" dependencies and comment similar to the
example, package/policycoreutils/Config.in with all its libsemanage
depends on.

> +
> +       help
> +               Graphic realtime audio programming language
> +               http://msp.ucsd.edu/software.htm

Suggest running ./utils/check-package package/puredata/*  to check for
formatting of the new files.

> diff --git a/package/puredata/puredata.hash b/package/puredata/puredata.hash
> new file mode 100644
> index 0000000000..505dbe3679
> --- /dev/null
> +++ b/package/puredata/puredata.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +d2e04e75d22b0e41f27daacc0cd6ec6b05ae0ef214cc7315d57e5bfbeec23fa3  pd-0.49-0.src.tar.gz

Please fix the format of this hash entry, see
https://buildroot.org/downloads/manual/manual.html#adding-packages-hash
for an example.  That looks like a sha256?

Please add a license file hash as well.

> diff --git a/package/puredata/puredata.mk b/package/puredata/puredata.mk
> new file mode 100644
> index 0000000000..842970b983
> --- /dev/null
> +++ b/package/puredata/puredata.mk
> @@ -0,0 +1,34 @@
> +################################################################################
> +#
> +# puredata
> +#
> +################################################################################
> +
> +PUREDATA_VERSION =  0.49-0
> +PUREDATA_SOURCE = pd-$(PUREDATA_VERSION).src.tar.gz
> +PUREDATA_SITE = http://msp.ucsd.edu/Software

Please add license type and file names. See
https://buildroot.org/downloads/manual/manual.html#generic-package-tutorial
for an example of the use of license variables.  Note, I understand
this is a autotools pkg type, the generic in the manual had the best
license example.

> +PUREDATA_INSTALL_STAGING = YES
> +PUREDATA_INSTALL_TARGET = YES

PUREDATA_INSTALL_TARGET is set defaultly to YES, so you can remove the line.

> +PUREDATA_AUTORECONF = YES
> +PUREDATA_CONF_OPTS = --no-recursion --disable-locales
> +
> +PUREDATA_DEPENDENCIES = alsa-utils tcl tk
> +
> +ifeq ($(BR2_PACKAGE_PORTAUDIO),y)
> +PUREDATA_CONF_OPTS += --enable-portaudio
> +else
> +PUREDATA_CONF_OPTS += --disable-portaudio
> +endif
> +
> +ifeq ($(BR2_PACKAGE_JACK2),y)
> +PUREDATA_CONF_OPTS += --enable-jack
> +else
> +PUREDATA_CONF_OPTS += --disable-jack
> +endif
> +
> +define PUREDATA_RUN_AUTOGEN
> +       cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> +endef
> +PUREDATA_PRE_CONFIGURE_HOOKS += PUREDATA_RUN_AUTOGEN
> +
> +$(eval $(autotools-package))
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

Matt