[Buildroot] [PATCH 1/1] package/autofs: fix mount, umount and fsck program paths

[Arnout Vandecappelle]

On 16/08/2019 11:09, Fabrice Fontaine wrote:
> Fixes:
>  - https://bugs.buildroot.org/show_bug.cgi?id=11876
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice at gmail.com>
> ---
>  package/autofs/autofs.mk | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/package/autofs/autofs.mk b/package/autofs/autofs.mk
> index e7c65ef4b0..5de399edf2 100644
> --- a/package/autofs/autofs.mk
> +++ b/package/autofs/autofs.mk
> @@ -11,11 +11,17 @@ AUTOFS_LICENSE = GPL-2.0+
>  AUTOFS_LICENSE_FILES = COPYING COPYRIGHT
>  AUTOFS_DEPENDENCIES = host-flex host-bison host-pkgconf host-nfs-utils
>  
> -# autofs looks on the build machine for the path of modprobe, so tell
> -# it explicitly where it will be located on the target.
> +# autofs looks on the build machine for the path of modprobe, mount, umount and
> +# fsck programs so tell it explicitly where it will be located on the target.
>  AUTOFS_CONF_ENV = \
> +	ac_cv_path_E2FSCK=/usr/sbin/fsck.ext2 \
> +	ac_cv_path_E3FSCK=/usr/sbin/fsck.ext3 \
> +	ac_cv_path_E4FSCK=/usr/sbin/fsck.ext4 \

 I must be blind or something, but e2fsprogs seem to install these in /sbin. Am
I missing something?

 Also, as noted by Thomas, these will only exist when e2fsprogs is installed. If
not, automounting any ext2/3/4 will not work because "fsck returned an error".

 It would seem to make more sense to me to set

	ac_cv_path_E2FSCK=/sbin/fsck \
	ac_cv_path_E3FSCK=no \
	ac_cv_path_E4FSCK=no \

 That way, the fsck wrapper always gets used (if the e3 and e4 versions don't
exist, the e2 version is used regardless of fs type).

 Regards,
 Arnout

>  	ac_cv_path_KRB5_CONFIG=no \
>  	ac_cv_path_MODPROBE=/sbin/modprobe \
> +	ac_cv_path_MOUNT=/bin/mount \
> +	ac_cv_path_MOUNT_NFS=/usr/sbin/mount.nfs \
> +	ac_cv_path_UMOUNT=/bin/umount \
>  	ac_cv_linux_procfs=yes
>  
>  # instead of looking in the PATH like any reasonable package, autofs
>