[Buildroot] [PATCH 01/10] infra/pkg-download: return just a list of URIs

Thomas Petazzoni thomas.petazzoni at bootlin.com
Sun Apr 7 12:20:52 UTC 2019


Hello Yann,

On Sun,  7 Apr 2019 13:51:16 +0200
"Yann E. MORIN" <yann.morin.1998 at free.fr> wrote:

> @@ -101,7 +101,7 @@ define DOWNLOAD
>  		-N '$($(PKG)_RAWNAME)' \
>  		-o '$($(PKG)_DL_DIR)/$(notdir $(1))' \
>  		$(if $($(PKG)_GIT_SUBMODULES),-r) \
> -		$(DOWNLOAD_URIS) \
> +		$(patsubst %,-u %,$(DOWNLOAD_URIS)) \

A patsubst here feels a bit awkward. What about a foreach instead, i.e:

		$(foreach uri,$(DOWNLOAD_URIS),-u $(uri))

 ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list