[Buildroot] [PATCH] motion: fix build failure due to missing drmGetVersion() and drmFreeVersion()

[Giulio Benetti]

Hello,09/09/2018 21:33, Giulio Benetti ha scritto:
> During static linking -ldrm is listed too early respect -lavutil.
> This cause build failure.
> 
> Append extra -ldrm at the tail of $(LIBS) list.
> 
> Fixes:
> http://autobuild.buildroot.net/results/395/395be1a9cab824b82ef34c2ebd84d54243029b33//
> 
> Signed-off-by: Giulio Benetti <giulio.benetti at micronovasrl.com>
> ---
>   ...-fix-static-linking-for-ldrm-library.patch | 30 +++++++++++++++++++
>   1 file changed, 30 insertions(+)
>   create mode 100644 package/motion/0002-Makefile.in-fix-static-linking-for-ldrm-library.patch
> 
> diff --git a/package/motion/0002-Makefile.in-fix-static-linking-for-ldrm-library.patch b/package/motion/0002-Makefile.in-fix-static-linking-for-ldrm-library.patch
> new file mode 100644
> index 0000000000..591cca66eb
> --- /dev/null
> +++ b/package/motion/0002-Makefile.in-fix-static-linking-for-ldrm-library.patch
> @@ -0,0 +1,30 @@
> +From 7098dafaf297d70bb73a5320bdc522b66c456a56 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti at micronovasrl.com>
> +Date: Sun, 9 Sep 2018 20:30:33 +0200
> +Subject: [PATCH] Makefile.in: fix static linking for -ldrm library
> +
> +While linking statically -ldrm library is listed too early than -lavutil.
> +
> +Append additional -ldrm entry to linker $(LIBS) list.
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti at micronovasrl.com>
> +---
> + Makefile.in | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/Makefile.in b/Makefile.in
> +index 94c7d40..5cfb490 100644
> +--- a/Makefile.in
> ++++ b/Makefile.in
> +@@ -39,7 +39,7 @@ CFLAGS       = @CFLAGS@ -Wall \
> + 	 -DMOTIONDOCDIR=\"$(DESTDIR)$(docdir)\"    \
> + 	 @FFMPEG_CFLAGS@ @MMAL_CFLAGS@
> + LDFLAGS      = @LDFLAGS@
> +-LIBS         = @LIBS@  @MMAL_LIBS@ @FFMPEG_LIBS@
> ++LIBS         = @LIBS@ @FFMPEG_LIBS@ @MMAL_LIBS@ -ldrm

As pointed here:
https://github.com/Motion-Project/motion/pull/800
It makes more sense to fix at FFmpeg level the variable FFMPEG_LIBS.
Otherwise this bug will keep coming out again and again.
So please discard this patch and I'm going to fix on ffmpeg package.

Thanks
Giulio Benetti