[Buildroot] [PATCH v2 0/5] Fix bug 11271 and add test for check-package
Ricardo Martincoski
ricardo.martincoski at gmail.com
Sun Nov 4 04:12:04 UTC 2018
Hello,
This series fixes bug 11271 and adds a test case that catches the bug.
Patch 1 fixes the usage of check-package when called from the same directory
than the files to be tested in a br2-external tree.
Patch 2 improves the testing infra by ensuring it can be started from any path,
not only the Buildroot top directory.
As a consequence the test infra will always test the repo it belongs to.
Patch 3 creates a test case for check-package, calling the script in the same
repo against in-tree files and against files in a br2-external.
Patch 4 improves usability of check-package in a br2-external tree by ignoring
external.mk since it is special: it usually contains raw makefile targets and
therefore cannot be tested by the script, but it is part of the br2-external
structure, so it is likely someone expects it to be checkable by an in-tree
script.
Patch 5 improves the test case created by patch 3 to test the scenario covered
by patch 4.
On below tests I used another series just to make my life easier:
http://patchwork.ozlabs.org/project/buildroot/list/?series=72927
1) to check patch 2 works and don't bring regressions: (I reused the urls for v1
because patch 2 did not change since v1 and also the master branch had no
change on support/testing since I sent v1)
A full run with only patch 2 applied:
https://gitlab.com/RicardoMartincoski/buildroot/pipelines/35290055
Another full run with only patch 2 applied, this time cd'ing to /tmp and
starting the tests from there:
https://gitlab.com/RicardoMartincoski/buildroot/pipelines/35290166
Without any patches of this series, cd'ing to /tmp and starting the tests from
there:
https://gitlab.com/RicardoMartincoski/buildroot/pipelines/35290220
2) to check patch 3 tests what patch 1 fixes:
With only patches 2 and 3 applied: failed
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/116174566
With patches 1, 2 and 3 applied: passed
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/116174639
3) to check patch 5 tests what patch 4 fixes:
With only patches 1, 2, 3 and 5 applied: failed
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/116174711
With all patches applied: passed
https://gitlab.com/RicardoMartincoski/buildroot/-/jobs/116174756
Changes v1 -> v2:
- do not absolutize paths on output (Vitaliy Lotorev)
- update expectation on the test case after changing patch 1: when a warning
is generated for a file from a br2-external and the file was specified in
the arguments as a relative path, the relative path is used in the warning
message
Regards,
Ricardo
Cc: Arnout Vandecappelle <arnout at mind.be>
Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
Cc: Vitaliy Lotorev <lotorev at gmail.com>
Cc: Yann E. MORIN <yann.morin.1998 at free.fr>
Ricardo Martincoski (5):
check-package: fix check of file in current dir with -b
support/testing: allow run-tests to be called from anywhere
support/testing: add test for check-package
check-package: ignore external.mk
support/testing: test check-package ignores external.mk
.gitlab-ci.yml | 1 +
support/testing/infra/__init__.py | 8 +-
support/testing/infra/builder.py | 2 +-
support/testing/tests/utils/__init__.py | 0
.../tests/utils/br2-external/Config.in | 1 +
.../tests/utils/br2-external/external.desc | 1 +
.../tests/utils/br2-external/external.mk | 2 +
.../br2-external/package/external/external.mk | 1 +
.../testing/tests/utils/test_check_package.py | 171 ++++++++++++++++++
utils/check-package | 3 +
utils/checkpackagelib/lib_mk.py | 7 +-
utils/checkpackagelib/lib_patch.py | 5 +-
12 files changed, 194 insertions(+), 8 deletions(-)
create mode 100644 support/testing/tests/utils/__init__.py
create mode 100644 support/testing/tests/utils/br2-external/Config.in
create mode 100644 support/testing/tests/utils/br2-external/external.desc
create mode 100644 support/testing/tests/utils/br2-external/external.mk
create mode 100644 support/testing/tests/utils/br2-external/package/external/external.mk
create mode 100644 support/testing/tests/utils/test_check_package.py
--
2.17.1
More information about the buildroot
mailing list