[Buildroot] [PATCH 2/2] board: amarula: a64-relic: Add WiFi support

[Thomas Petazzoni]

Hello,

On Wed, 30 May 2018 23:40:59 +0200, Arnout Vandecappelle wrote:

> > + # wpa_passphrase ACCESSPOINTNAME >> /etc/wpa_supplicant.conf
> > +   (type password and enter)
> > + # wpa_supplicant -i wlan0 -c /etc/wpa_supplicant.conf -B
> > + # udhcpc -i wlan0  
> 
>  Could we add the latter two to an init script instead? Should be S40 so it
> coincides with S40network from ifupdown-scripts.
> 
>  So in the readme, these two lines would then be replaced with
> 
> # /etc/init.d/S40wlan start

I'm not sure how that would work. You first need to enter the
passphrase for the WiFi chip to associate with the AP, and therefore
before doing the udhcp.

So when you suggest to replace the last two lines by
"/etc/init.d/S40wlan start", how is this going to work considering that
starting the S40wlan script has already been done at boot time ?

> > +load_modules()
> > +{
> > +	while IFS= read -r line; do
> > +		modprobe -a $line
> > +	done < "/etc/modules-load.d/modules.conf"
> > +}
> > +
> > +load_modules
> > +echo "Loading modules: OK"  
> 
>  Init scripts should handle the start and stop arguments, otherwise the module
> will be loaded again during shutdown.
> 
>  Also, I don't think it makes a lot of sense to introduce all this flexibility.
> Just include 'modprobe -a brcmfmac' to S40wlan.

Not directly related to Jagan's submission, but we do have this need to
load modules at startup for a number of platforms. Isn't it time to
have a generic init script that reads /etc/modules for this ? It's also
a question that has been asked a number of times on IRC: "how do I ask
my Buildroot system to load a kernel module at startup". Of course the
answer is simple: add an init script, but since the question has been
asked many times, perhaps it's worth adding some generic script ?

Or maybe in this case mdev support should be enabled to ensure modules
are loaded automatically ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com