[Buildroot] [PATCH 6/8] ti-sgx-km: rename options to have proper prefix

Arnout Vandecappelle arnout at mind.be
Tue May 22 10:42:13 UTC 2018



On 21-05-18 23:16, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
> 
>  > On 16-05-18 09:00, Thomas Petazzoni wrote:
>  >> Hello,
>  >> 
>  >> On Tue, 15 May 2018 23:52:33 +0200, Arnout Vandecappelle wrote:
>  >> 
>  >>>> What is nice with this solution, is that we have the new choice that is
>  >>>> right near the legacy option so we can chek it, and it automatically
>  >>>> gets the old setting.
>  >>>> 
>  >>>> But I am not too convinced, however, because we do not usually use the
>  >>>> name of a choice elsewhere...  
>  >>> 
>  >>> Legacy is pretty special anyway. I do think it's worthwhile it to do this properly.
>  >> 
>  >> Is this an Acked-by to the approach this patch series has taken in
>  >> terms of handling the Config.in choice option renaming ?
> 
>  >  Er, no, it's a NACK. I *do* think it's worthwhile to properly select the new
>  > option.
> 
> OK. I would like to release RC2 and include these renames, so how about
> you send a followup series with the reworked Config.in.legacy handling?

 At the pace that I've been active in Buildroot lately, not likely, but I'll
give it a shot :-)

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF



More information about the buildroot mailing list