[Buildroot] [PATCH v2] dropbear: Do not build static binary

[Baruch Siach]

Hi Stefan,

On Mon, May 07, 2018 at 02:28:43PM +0200, Stefan Sørensen wrote:
> Dropbear 2018.76 now uses the --enable-static option to indicate that a static
> binary should be built. This will incorrectly pick up the generic buildroot
> option intended for building static libraries, causing an unwanted static
> binary build with BR2_SHARED_STATIC_LIBS.
> 
> Fix by appending an --disable-static configure flag, overriding the buildroot
> default.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen at spectralink.com>

Reviewed-by: Baruch Siach <baruch at tkos.co.il>

baruch

> ---
> Changes v1->v2:
>  * Keep the --enable-static when BR2_STATIC_LIBS=y
> 
>  package/dropbear/dropbear.mk | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/package/dropbear/dropbear.mk b/package/dropbear/dropbear.mk
> index 1da1a559a3..fc41a84c1f 100644
> --- a/package/dropbear/dropbear.mk
> +++ b/package/dropbear/dropbear.mk
> @@ -27,8 +27,11 @@ DROPBEAR_MAKE = \
>  	$(MAKE) MULTI=1 SCPPROGRESS=1 \
>  	PROGRAMS="$(DROPBEAR_PROGRAMS)"
>  
> -ifeq ($(BR2_STATIC_LIBS),y)
> -DROPBEAR_CONF_OPTS += --enable-static
> +# With BR2_SHARED_STATIC_LIBS=y the generic infrastructure adds a
> +# --enable-static flags causing dropbear to be built as a static
> +# binary. Adding a --disable-static reverts this
> +ifeq ($(BR2_SHARED_STATIC_LIBS),y)
> +DROPBEAR_CONF_OPTS += --disable-static
>  endif
>  
>  # Ensure that dropbear doesn't use crypt() when it's not available

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -