[Buildroot] [PATCH v2 2/2] configs/imx7d-sdb: Add new defconfig

Thomas Petazzoni thomas.petazzoni at bootlin.com
Wed Jul 18 12:51:46 UTC 2018


Hello,

On Wed, 18 Jul 2018 09:21:39 -0300, Fabio Estevam wrote:

> > However, I find the naming a bit strange. If I understand correctly
> > freescale_imx7dsabresd_defconfig and imx7d-sdb_defconfig are for the
> > same board, the former using the vendor kernel, the latter using the
> > mainline kernel. If that's the case, why isn't the defconfig having the
> > same name, except for the freescale_ prefix ?  
> 
> For boards that use mainline kernel and U-Boot I try to name its
> Buildroot defconfig using the same convention used in its device tree:
> <soc>-<board>, so that is why I used imx7d-sdb_defconfig.

That makes sense. So I guess the DT name in the vendor kernel is
different, and that's why our defconfigs have a different name between
the vendor and mainline variants for a given board ?

> > Also, the board folder is named "imx7dsdb", which isn't very consistent.  
> 
> Yes, I can change it to "imx7d-sdb" for better consistency.

Yeah, that's just a minor detail :-) However, it still wouldn't be very
consistent with the name of the defconfig for the vendor u-boot/kernel
variant.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com



More information about the buildroot mailing list