[Buildroot] [PATCH 1/1] ncmpc: fix build with some old toolchains

[Fabrice Fontaine]

Dear Thomas,

2018-08-12 16:01 GMT+02:00 Thomas Petazzoni <thomas.petazzoni at bootlin.com>:

> Hello,
>
> On Sun, 12 Aug 2018 15:52:07 +0200, Fabrice Fontaine wrote:
>
> > > To be honest, I don't have enough C++ knowledge to figure out if this
> > > is the right fix, but I've applied to master anyway. Please submit
> > > upstream to get a proper review. Thanks!
> > >
> > I sent it upstream (https://github.com/MusicPlayerDaemon/ncmpc/pull/29)
> but
> > the PR has been closed :-/
>
> Considering upstream's reaction, perhaps we should drop the patch, and
> add the appropriate BR2_TOOLCHAIN_HAS_GCC_AT_LEAST_... dependency ?
>
 Indeed, you're right. I will send a new patch to add a dependency to gcc
>= 5.6.

>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
Best Regards,

Fabrice
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildroot.org/pipermail/buildroot/attachments/20180812/bcbbd526/attachment-0001.html>