[Buildroot] [PATCH 1/1] ntp: add patch to support for libressl

[Arnout Vandecappelle]

On 23-11-17 22:51, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed,  8 Nov 2017 07:11:43 -0500, Adam Duskett wrote:
>> NTP currently fails to compile against LibreSSL because of checks used
>> to determine the SSL library version.
>>
>> Upstream-Status: Pending
>> http://bugs.ntp.org/show_bug.cgi?id=3401#c3
>>
>> Signed-off-by: Adam Duskett <aduskett at gmail.com>
> 
> Arnout, Peter, Yann, I think we discussed this topic during the
> Buildroot meeting, and concluded we didn't want patches in Buildroot to
> enable LibreSSL compatibility with a package. Do we stand on this
> position, and reject Adam's contribution on ntp?

 I don't think the conclusion was that we would reject patches to enable
LibreSSL compatibility outright, only:

> 
>> + #ifndef OPENSSL_VERSION_NUMBER
>> ++#ifndef LIBRESSL_VERSION_NUMBER
> 
> In addition, this continue to use the LIBRESSL_VERSION_NUMBER approach,
> which will fail when libressl gains support for new APIs.

 we would reject this approach because I believe it is not upstreamable.

 I think upstreamable patches are acceptable. And maybe even the
LIBRESSL_VERSION_NUMBER approach is OK - but then I first want to see a reliable
upstream accept it.


 Regards,
 Arnout

> 
> Thanks in advance for giving your feedback on this patch. If nobody
> complains, I'll merge :-)
> 
> Thanks!
> 
> Thomas
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF