[Buildroot] [PATCH v1] libxkbcommon: add support for interactive-wayland test program
Peter Seiderer
ps.report at gmx.net
Fri Mar 10 19:31:59 UTC 2017
Hello Thomas,
On Thu, 9 Mar 2017 22:18:50 +0100, Thomas Petazzoni <thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Wed, 8 Mar 2017 22:53:10 +0100, Peter Seiderer wrote:
>
> > +if BR2_PACKAGE_LIBXKBCOMMON && BR2_PACKAGE_WAYLAND
> > +
> > +config BR2_PACKAGE_LIBXKBCOMMON_INTERACTIVE_WAYLAND
> > + bool "interactive-wayland"
> > + select BR2_PACKAGE_WAYLAND_PROTOCOLS
> > + help
> > + interactive-wayland is a wayland test application
> > + for libxkbcommon.
> > +
> > +endif
>
> This looks like a very very specific option. Shouldn't this be instead
> BR2_PACKAGE_LIBXKBCOMMON_INSTALL_TESTS ?
It is specific, did not find a target to build all tests (see below)...
>
> > +define LIBXKBCOMMON_BUILD_INTERACTIVE_WAYLAND
> > + $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) test/interactive-wayland
> > +endef
> > +LIBXKBCOMMON_POST_BUILD_HOOKS = LIBXKBCOMMON_BUILD_INTERACTIVE_WAYLAND
>
> There's already some logic in the build system to build tests. Can't we
> use it instead?
'make test' does nothing, 'make check' builds the tests AND tries (and fails)
to run the test programs...
Regards,
Peter
>
> Thanks,
>
> Thomas
More information about the buildroot
mailing list