[Buildroot] [PATCH 1/5] support/testing: core testing infrastructure

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Mar 5 14:09:46 UTC 2017


Hello,

On Wed, 01 Mar 2017 22:46:17 -0300, Ricardo Martincoski wrote:

> Support for arch="i386" from test_iso9660 is missing here:
>         else:
>             qemu_arch = arch

Re-added this. I guess it had been lost during one of the cleanup
sessions. I've retested one of the iso9660 test cases, and it now
passes correctly.

> Maybe we can do for now as scanpypi does:
> #!/usr/bin/python2

Fixed.

> > +import string  
> 
> Not used.

Ditto.

> > +    if not os.path.exists(args.output):
> > +        print "The selected output directory does not exist"
> > +        return 1
> > +
> > +    BRTest.outputdir = args.output  
> 
> Maybe changing this line to:
>     BRTest.outputdir = os.path.abspath(args.output)
> would fix the use of relative path with some testcases.

Indeed, this fixes the problem you mentioned.

All of this will be in v2. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list