[Buildroot] [PATCH 2/2] mke2img: add parameter sanity checks to prevent odd error messages from genext2.fs

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Apr 30 09:32:59 UTC 2017


Hello,

On Sun, 30 Apr 2017 11:25:33 +0200, Yann E. MORIN wrote:

> > $ ./package/mke2img/mke2img -b
> > mke2img: option 'b' expects a mandatory argument
> > 
> > So it is already checked that ${nb_blocks} cannot be empty.  
> 
> But if you don't pass the -b option, then nb_blocks *is* unset.
> 
> Adding the check is correct in my opinion.

Ah, yes agreed.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list