[Buildroot] [PATCH 1/1] busybox: preserve ncurses progs/tools

Peter Korsgaard peter at korsgaard.com
Sun Apr 23 18:03:14 UTC 2017


>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:

 > Hello,
 > On Fri, 14 Apr 2017 19:00:32 +0200, Arnout Vandecappelle wrote:

 >> This is the correct approach I think. I think we could also do this for all the
 >> other cases where we have a -> busybox dependency just because they install the
 >> same apps.

 > Yes, I'm also wondering if it isn't better to disable the Busybox
 > applets (like Matt does in this patch for ncurses) rather then
 > overwriting the symlinks.

 > First of all, overwriting the symlinks means that if you "make
 > busybox-reinstall", you no longer get the right thing (for sure, we
 > never guarantee that partial builds/rebuilds give the correct output,
 > but it's nice when they do). And then of course, it means that there is
 > code in Busybox, consuming some space, that is never used.

 > The only annoyance that I can see is a potential blotification of
 > busybox.mk, with lots of conditional for various packages.

That and the fact that we're adding more "magic" to silently override
the configuration behind the users' back. I get it that people may be
less likely to tweak their busybox config than E.G. the kernel, but just
like for the kernel config I prefer to keep the config overrides to the
minimum.

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list