[Buildroot] [PATCH 2/7] package configs: clean up ordering.

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Apr 22 13:56:39 UTC 2017


Hello,

On Fri, 21 Apr 2017 11:24:47 -0400, Adam Duskett wrote:
> The check-package script when ran gives warnings on ordering issues
> on all of these Config files.  This patch cleans up all warnings
> related to the ordering in the Config files in the package directory.
> 
> The appropriate ordering is: type, default, depends on, select, help
> See http://nightly.buildroot.org/#_config_files for more information.
> 
> Signed-off-by: Adam Duskett <aduskett at codeblue.com>

This is really too long/too boring to review. I believe this should
rather be done progressively, or split into smaller patches. One patch
per package is quite certainly too much. Maybe one patch for packages
starting with "a", one for packages starting with "b", etc.

But don't send the whole thing at once. We don't want to have the
patchwork backlog flooded by cleanup patches.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com



More information about the buildroot mailing list