[Buildroot] [PATCH 01/10] core: do not hard-code inclusion of br2-external in Kconfig
Yann E. MORIN
yann.morin.1998 at free.fr
Sun Sep 25 17:32:02 UTC 2016
Romain, All,
On 2016-09-25 19:21 +0200, Romain Naour spake thusly:
> Le 25/09/2016 à 16:52, Yann E. MORIN a écrit :
> > Move the inclusion of br2-external's Config.in to the generated kconfig
> > snippet.
> >
> > This will ultimately allow us to use more than one br2-external tree.
> >
> > Offload the "User-provided options" menu to the generated Kconfig
> > snippet. We can also move the definition of the Kconfig-version of
> > BR2_EXTERNAL into this snippet.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> > Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> > Cc: Arnout Vandecappelle <arnout at mind.be>
> > Cc: Romain Naour <romain.naour at openwide.fr>
[--SNIP--]
> > diff --git a/support/scripts/br2-external b/support/scripts/br2-external
> > new file mode 100755
> > index 0000000..c15c21c
> > --- /dev/null
> > +++ b/support/scripts/br2-external
> > @@ -0,0 +1,85 @@
> > +#!/bin/bash
> > +set -e
[--SNIP--]
> > +# Validates the br2-external tree passed as argument. Makes it cannonical
> > +# and store it in global variable BR2_EXT.
> > +do_validate() {
> > + local br2_ext="${1}"
> > +
> > + if [ ! -d "${br2_ext}" ]; then
> > + error "'%s': no such file or directory\n" "${br2_ext}"
> > + fi
> > +
> > + BR2_EXT="$(cd "${br2_ext}"; pwd -P )"
>
> br2_ext can be a directory on which we may not have access, so cd will fail here.
You really want to find a reason for me to respin this series so it gets
in patchwork, don't you? ;-)
Indeed, that would return Buildroot's top directory, which is not
correct.
Thanks for noticing.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
More information about the buildroot
mailing list