[Buildroot] [PATCH 1/1] avahi: link with libintl if libglib2 is enabled

[Waldemar Brodkorb]

Hi,
Arnout Vandecappelle wrote,

> On 19-10-16 18:23, Johan Oudinet wrote:
> > On Wed, Oct 19, 2016 at 2:59 PM, Thomas Petazzoni
> > <thomas.petazzoni at free-electrons.com> wrote:
> >> > On Wed, 19 Oct 2016 14:42:45 +0200, Johan Oudinet wrote:
> >> >
> >>>>> >> >> -AVAHI_MAKE_OPTS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),LIBS=-lintl)
> >>>>> >> >> +# If either locale or libglib2 is defined, avahi needs libintl.
> >>>>> >> >> +AVAHI_MAKE_OPTS += \
> >>>>> >> >> +     $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE)$(BR2_PACKAGE_LIBGLIB2),LIBS=-lintl)
> >>>> >> >
> >>>> >> > Hum, I wondering if it wouldn't be nicer to rely on the fact that the
> >>>> >> > Config.in of those packages enable BR2_PACKAGE_GETTEXT when necessary.
> >>>> >> > So maybe we should instead rely on BR2_PACKAGE_GETTEXT=y, with
> >>>> >> > something like:
> >>>> >> >
> >>>> >> > ifeq ($(BR2_PACKAGE_GETTEXT),y)
> >>>> >> > AVAHI_DEPENDENCIES += gettext
> >>>> >> > AVAHI_MAKE_OPTS += LIBS=-lintl
> >>>> >> > endif
> >>>> >> >
> >>>> >> > (and of course, remove the gettext dependency added conditionally on
> >>>> >> > BR2_NEEDS_GETTEXT_IF_LOCALE).
> >>>> >> >
> >>>> >> > It would be necessary to also test this with musl and glibc
> >>>> >> > configurations, with gettext enabled, to make sure it doesn't break.
> >>>> >> >
> >>>> >> > And if it works, then we should update the Buildroot manual, which has
> >>>> >> > a section on the gettext integration.
> >>> >>
> >>> >> Good idea. I'm trying it and if it works, I'll send a patch serie. One
> >>> >> to modify the documentation, and one to update every packet that
> >>> >> integrates gettext.
> >> >
> >> > Could you please send the documentation patch alone first, so we can
> >> > validate the approach (i.e not only me, but also other folks in
> >> > Buildroot), before you spend time on reworking all the packages. This
> >> > way, we can all agree on the new approach first.
> >> >
> > Sure. However, It does break if I activate gettext with glibc:
> 
>  That was exactly my concern with Thomas's proposal...
> 
>  I would say: don't touch this now, and schedule it for discussion at the next
> BR developer meeting.

Just want to mention that I want integrate gettext-tiny into
uClibc-ng soon. It is a stub implementation. The existing stub isn't
selectable since a while...

https://github.com/rofl0r/gettext-tiny

best regards
 Waldemar