[Buildroot] [PATCH 1/2] check-host-rpath: support symlinks in rpath

[Arnout Vandecappelle]

 Hi Jerome,

On 05-10-16 10:54, Jérôme Pouiller wrote:
> Hi Arnout,
> 
> On Tuesday 04 October 2016 23:33:34 Arnout Vandecappelle wrote:
>> On 30-09-16 12:09, Jérôme Pouiller wrote:
>>> If compilation path contains symlinks, rpath may sometime contains
>>> symlinks and sometime canonicalized path.
>>>
>>> A pratical example:
>>>   $ ln -s /opt/buildroot /opt/buildroot-symblink
>>>   $ cd /opt/buildroot-symlink
>>>   $ make O=out
>>>   $ make -C out package-rebuild
>>>
>>> This last command produce an error since already installed host
>>> binaries contains /opt/buildroot/out/host/usr/lib as rpath while
>>> check-host-rpath expect /opt/buildroot-symlink/out/host/usr/lib
>>>
>>> This patch canonicalize all paths used in check-host-rpath in order
>>> to avoid problem
>>
>>  Wouldn't this also be fixed by
>> http://patchwork.ozlabs.org/patch/613854/ ? With that patch (series)
>> applied, there shouldn't be any symlinks anymore once the real make
>> starts.
> 
> I didn't saw Samuel's patch. I will test it soon. I think it supersede 
> mine.

 You never came back to this. We will apply Samuel's patches soon. Can you
re-test after that and resubmit your patches if still needed?

 I've marked you patches as Rejected for now.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF