[Buildroot] [PATCH 3/4] netatop: enable required kernel feature

Ricardo Martincoski ricardo.martincoski at gmail.com
Sat Oct 8 20:45:44 UTC 2016


Thomas,

On Fri, Oct 07, 2016 at 06:20 PM, Thomas Petazzoni wrote:

> On Fri,  7 Oct 2016 17:30:30 -0300, Ricardo Martincoski wrote:
>> When netatop is enabled, the required kernel feature is enabled.
>> 
>> Signed-off-by: Ricardo Martincoski <ricardo.martincoski at datacom.ind.br>
> 
> Is CONFIG_NETFILTER=y required to *build* the netatop module, or only
> needed at runtime ?

It is required to build the module.

> 
> Two cases:
> 
>  - If it's needed to build the netatop module, then this change should
>    be part of the commit adding the netatop package.

Ok. I will send both in one commit when I respin.

> 
>  - If it's needed only at runtime, we have a more relaxed policy, and we
>    generally don't enforce the kernel options in such a case.
> 

Thank you for your review.

Regards,
Ricardo


More information about the buildroot mailing list