[Buildroot] [PATCH v2] htop: enable unicode if possible
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Tue Nov 15 12:03:28 UTC 2016
Hello,
On Mon, 14 Nov 2016 12:04:48 +0100, Jérôme Pouiller wrote:
> +ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),)
You should have used positive logic instead:
ifeq ($(BR2_PACKAGE_NCURSES_WCHAR),y)
enable feature
else
disable feature
endif
> +HTOP_CONF_OPTS = --disable-unicode
You should use += here instead of =, since we are in a condition. This
helps avoiding stupid bugs in the future, if additional CONF_OPTS
assignments are added earlier in the file.
Applied to next with those two issues fixed.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list