[Buildroot] [PATCH] infra: fix striping of ld.so and libpthread

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Nov 9 22:18:38 UTC 2016


Hello,

Thanks for contributing this patch, this was definitely buggy.

In the commit title: striping -> stripping.

On Wed,  9 Nov 2016 11:57:27 +0100, Jérôme Pouiller wrote:
> If 'lib' is a symlink, 'find lib' does not return correct result. So, until now,

return *the* correct result. Also, it would have been good to explain
that this typically occurs when the "merged /usr" option is enabled.

> libpthread*.so* and ld-*.so* was not stripped when 'lib' was a symlink.
> 
> We fix tit by using 'find lib/' instead of 'find lib'

We fix *this*.

> @@ -644,7 +644,7 @@ target-finalize: $(PACKAGES)
>  		$(TARGET_DIR)/usr/lib/pkgconfig $(TARGET_DIR)/usr/share/pkgconfig \
>  		$(TARGET_DIR)/usr/lib/cmake $(TARGET_DIR)/usr/share/cmake
>  	find $(TARGET_DIR)/usr/{lib,share}/ -name '*.cmake' -print0 | xargs -0 rm -f
> -	find $(TARGET_DIR)/lib $(TARGET_DIR)/usr/lib $(TARGET_DIR)/usr/libexec \
> +	find $(TARGET_DIR)/lib/ $(TARGET_DIR)/usr/lib/ $(TARGET_DIR)/usr/libexec/ \

This change should have been explained in the commit log: it's just
done for consistency, but doesn't fix anything by itself.

I've applied to master with those various issues fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com



More information about the buildroot mailing list