[Buildroot] [PATCH v3 6/6] package/amd-catalyst-driver: Add AMD proprietary graphic stack support

[Yann E. MORIN]

Thomas, Romain, All,

On 2016-07-27 21:36 +0200, Thomas Petazzoni spake thusly:
> On Wed, 27 Jul 2016 18:24:08 +0200, Yann E. MORIN wrote:
> 
> > > So, either you merge a package containing a module which won't build
> > > or you ask the user to patch manually his kernel...  
> > 
> > And this is exactly what we should not even mention, IMHO.
> > 
> > So, my deepest opinion is that we should *not* have that package at all,
> > given that it can't build/run.
> > 
> > However, as Thomas said and as you will have experienced, this is not
> > something that is easy to package, and some people need it. We can at
> > least provide the recipe to build it; this is obviously not the best
> > solution, as it won't work out-of-the-box.
> > 
> > Yes, we will provide a package that cannot build and, even if it would,
> > would not run. No, we can't do anything about it. No, we should *not*
> > try to do anything about it.
> 
> I discussed it with Romain today and here is my proposal: we simply
> don't do anything to try to fix this problem. It is up to the user to
> figure out what is the most acceptable solution (if any).

Agreed.

> This way, the most complicated packaging part is in Buildroot upstream,
> which makes 99% of the work simpler for our users, they "simply" have
> to deal with this licensing oddity.

Agreed.

> We can simply add a warning in the Config.in help text of the package
> that it may not build due to the proprietary kernel module using kernel
> symbols not exposed to proprietary modules.

Agreed.

> How does that sound?

I thought I was explicit in my inital review (where I suggested your own
blurb for the help text), and in my subsequent reply (where I said "Yes,
we will provide a package that cannot build").

To clarify: I am OK with the proposal to add the package with a help
text that explains (briefly) why "the package may not build or run",
but that does not offer any hint as to how this can be circumvented.

(I was a bit busy tonight, so I could not reply to your other comments
about my review; I'll do so tomorrow or during the WE.)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'