[Buildroot] [v2 2/5] package/audit: add support for host variant

[Thomas Petazzoni]

Hello,

On Sat, 16 Jul 2016 16:06:26 -0400, Adam Duskett wrote:
> refpolicy requires host-audit to compile.  This patch adds that support.
> As previously discussed, libcap-ng is required as far as I can tell, and
> as such, I have made it mandatory to compile it as a dependency.

Don't use first person sentences in commit log.

> Signed-off-by: Adam Duskett <Aduskett at gmail.com>
> ---
> Changes:
> 
> v1 - v2:
>  - Removed frivilous check for libcap-ng
>  - made host-libcap-ng mandatory.
> 
>  package/audit/audit.mk | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/package/audit/audit.mk b/package/audit/audit.mk
> index 89fdf14..1300c72 100644
> --- a/package/audit/audit.mk
> +++ b/package/audit/audit.mk
> @@ -58,4 +58,7 @@ define AUDIT_INSTALL_CLEANUP
>  endef
>  AUDIT_POST_INSTALL_TARGET_HOOKS += AUDIT_INSTALL_CLEANUP
>  
> +HOST_AUDIT_CONF_OPTS = --without-python --without-python3 --disable-zos-remote --with-libcap-ng=yes

So you use libcap-ng, but you don't depend on it? Doesn't seem right.
Also, it would be good to be really sure it is needed. Did you try
without it? How do you test this patch series?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com