[Buildroot] [PATCH] package/python-pillow: fix wrong install step

[Thomas Petazzoni]

Hello,

On Wed, 6 Jul 2016 14:51:26 +0200, Angelo Compagnucci wrote:

> > What are you doing the build_ext target again here?  
> 
> python pillow build command is:
> 
> python setup.py build_ext --enable-[feature]
> 
> and installation command is:
> 
> python setup.py build_ext --enable-[feature] install
> 
> It doesn't work either way, see the documentation here [1].

Ah, ok. Thanks for the explanation. I hate to say I dislike what the
python-pillow package needs to do, but there isn't a better option for
now with the current python-package infrastructure. We'll live with
that for now, and potentially improve the python-package infrastructure
in the future if more packages have similar requirements.

> >> +             $(PYTHON_PILLOW_BUILD_OPTS) install \
> >> +             $(PYTHON_PILLOW_BASE_INSTALL_TARGET_OPTS) \
> >> +             $(PYTHON_PILLOW_INSTALL_TARGET_OPTS)  
> >
> > Also, please use define ... endef for those commands (ditto for the
> > build command, I missed that when applying the patch).  
> 
> Define what? They are the manadtory build and installation commands,
> why make them conditional?

Use:

define PYTHON_PILLOW_BUILD_CMDS
	...
endef

instead of

PYTHON_PILLOW_BUILD_CMDS = ...

Ditto for the install target commands.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com