[Buildroot] [PATCH 1/6] package/mesa3d: reorder select/depends

Peter Korsgaard peter at korsgaard.com
Mon Jan 4 23:22:38 UTC 2016


>>>>> "Romain" == Romain Naour <romain.naour at gmail.com> writes:

 >> From [1]:
 > "Even though the ordering has absolutely no consequences in Kconfig, it
 > is not logical (when reading). It is more logical and far easier to
 > understand when depends come first, followed by the selects."

 > Also, the Config.in exemple in the manual suggest to use this coding
 > style [2].

 > [1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
 > [2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in

 > Signed-off-by: Romain Naour <romain.naour at gmail.com>

Committed patch 1-5, thanks. I had already applied a similar patch from
Gustavoz for xapp_xbacklight. That one didn't select libxcb though, but
I guess it doesn't really matter as libX11 pulls it in.

(xcb-util should arguably select libxcb as it is a library instead of
using depends on).

-- 
Bye, Peter Korsgaard



More information about the buildroot mailing list