[Buildroot] [PATCH 1/2] package/sysdig: reorder select/depends

Romain Naour romain.naour at gmail.com
Fri Jan 1 20:02:21 UTC 2016


>From [1]:
"Even though the ordering has absolutely no consequences in Kconfig, it
is not logical (when reading). It is more logical and far easier to
understand when depends come first, followed by the selects."

Also, the Config.in exemple in the manual suggest to use this coding
style [2].

[1] http://lists.busybox.net/pipermail/buildroot/2015-October/142955.html
[2] http://buildroot.uclibc.org/downloads/manual/manual.html#writing-rules-config-in

Signed-off-by: Romain Naour <romain.naour at gmail.com>
---
 package/sysdig/Config.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/sysdig/Config.in b/package/sysdig/Config.in
index dc71d5f..151e75d 100644
--- a/package/sysdig/Config.in
+++ b/package/sysdig/Config.in
@@ -1,12 +1,12 @@
 config BR2_PACKAGE_SYSDIG
 	bool "sysdig"
-	select BR2_PACKAGE_ZLIB
-	select BR2_PACKAGE_LUAJIT
-	select BR2_PACKAGE_JSONCPP
 	depends on BR2_LINUX_KERNEL
 	depends on BR2_INSTALL_LIBSTDCPP # libjson
 	depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	depends on !BR2_STATIC_LIBS # luajit
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT
+	select BR2_PACKAGE_JSONCPP
 	help
 	  Sysdig is open source, system-level exploration:
 	  capture system state and activity from a running Linux instance,
-- 
2.4.3




More information about the buildroot mailing list