[Buildroot] [PATCH v2] board: Add support for Acmesystems Arietta g25

[Thomas Petazzoni]

Dear Angelo Compagnucci,

On Wed,  3 Feb 2016 23:15:10 +0100, Angelo Compagnucci wrote:

>  board/acmesystems/arietta-g25/genimage.cfg      | 35 +++++++++++++++++++++++++
>  board/acmesystems/arietta-g25/post-image.sh     | 16 +++++++++++
>  board/acmesystems/arietta-g25/readme.txt        | 24 +++++++++++++++++
>  configs/acmesystems_arietta_g25_128mb_defconfig | 31 ++++++++++++++++++++++
>  configs/acmesystems_arietta_g25_256mb_defconfig | 31 ++++++++++++++++++++++
>  5 files changed, 137 insertions(+)
>  create mode 100644 board/acmesystems/arietta-g25/genimage.cfg
>  create mode 100755 board/acmesystems/arietta-g25/post-image.sh
>  create mode 100644 board/acmesystems/arietta-g25/readme.txt
>  create mode 100644 configs/acmesystems_arietta_g25_128mb_defconfig
>  create mode 100644 configs/acmesystems_arietta_g25_256mb_defconfig
> 
> diff --git a/board/acmesystems/arietta-g25/genimage.cfg b/board/acmesystems/arietta-g25/genimage.cfg
> new file mode 100644
> index 0000000..b2b55e8
> --- /dev/null
> +++ b/board/acmesystems/arietta-g25/genimage.cfg
> @@ -0,0 +1,35 @@
> +# Minimal SD card image for the Acmesystems Arietta G25
> +#
> +image boot.vfat {
> +	vfat {
> +		file zImage {
> +			image = "zImage"
> +		}
> +
> +		file acme-arietta.dtb {
> +			image = "at91-ariag25.dtb"
> +		}
> +
> +		file boot.bin{
> +			image = "at91sam9x5_arietta-sdcardboot-linux-zimage-dt-3.7.bin"
> +		}
> +	}
> +	size = 15M

Why 15M and not 16M, which seems more logical for computer people?


> diff --git a/board/acmesystems/arietta-g25/readme.txt b/board/acmesystems/arietta-g25/readme.txt
> new file mode 100644
> index 0000000..076be21
> --- /dev/null
> +++ b/board/acmesystems/arietta-g25/readme.txt
> @@ -0,0 +1,24 @@

Maybe a short introduction here to say which board this document
applies to with a link to the official web site of the board would be
good.

> +Build instructions
> +==================
> +
> +As a regular user configure and then build:

No need to say "As a regular user" I believe.

> +
> +$ make acmesystems_arietta_g25_128mb_defconfig (128MB RAM variant)
> +
> +or...
> +
> +$ make acmesystems_arietta_g25_256mb_defconfig (256MB RAM variant)
> +
> +then:
> +
> +$ make
> +
> +How to write the SD card
> +========================
> +
> +Once the build process is finished you will have an image called "sdcard.img"
> +in the output/images/ directory.
> +
> +Copy the bootable "sdcard.img" onto an SD card with "dd":
> +
> +  $ sudo dd if=output/images/sdcard.img of=/dev/sdX

There are no instructions on how to use the system on the platform,
like a button to push or anything like that?

> diff --git a/configs/acmesystems_arietta_g25_128mb_defconfig b/configs/acmesystems_arietta_g25_128mb_defconfig
> new file mode 100644
> index 0000000..f6bf310
> --- /dev/null
> +++ b/configs/acmesystems_arietta_g25_128mb_defconfig
> @@ -0,0 +1,31 @@
> +# Architecture
> +BR2_arm=y
> +
> +# Toolchain
> +BR2_KERNEL_HEADERS_VERSION=y
> +BR2_DEFAULT_KERNEL_VERSION="4.1.1"
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
> +
> +# Kernel
> +BR2_LINUX_KERNEL=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.1.1"
> +BR2_LINUX_KERNEL_DEFCONFIG="at91_dt"
> +BR2_LINUX_KERNEL_ZIMAGE=y
> +BR2_LINUX_KERNEL_DTS_SUPPORT=y
> +BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-ariag25"
> +BR2_LINUX_KERNEL_XZ=y
> +
> +# Bootloader
> +BR2_TARGET_AT91BOOTSTRAP3=y
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="git://github.com/tanzilli/at91bootstrap.git"
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="cedbde4b36695b715f469f4872f47e5cc8115000"
> +BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="arietta-128m"
> +
> +# Image
> +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/acmesystems/arietta-g25/post-image.sh"
> +BR2_TARGET_ROOTFS_EXT2=y
> +BR2_TARGET_ROOTFS_EXT2_4=y
> +# BR2_TARGET_ROOTFS_TAR is not set
> +BR2_PACKAGE_HOST_GENIMAGE=y

You need to add the following line:

BR2_PACKAGE_HOST_DOSFSTOOLS=y
BR2_PACKAGE_HOST_MTOOLS=y

otherwise I believe your defconfig will not build (unless of course you
have those tools installed on your system, but since they are not part
of the mandatory dependencies of Buildroot, we have to build them).

They are needed for genimage to create the VFAT filesystem containing
the bootloader, DT and kernel.

Could you fix those (minor) issues and send an updated version?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com