[Buildroot] [PATCH 01/10] firmware-imx: bump to version 5.2

[Gary Bisson]

Thomas, All,

On Mon, Feb 1, 2016 at 9:39 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Dear Gary Bisson,
>
> On Sat, 30 Jan 2016 12:45:48 +0100, Gary Bisson wrote:
>
>> The package adds the EPDC waveforms and the needed changes to properly
>> install those were done in the firmware-imx.inc file.
>
> I guess you wanted to say firmware-imx.mk. Maybe you've done too much
> Yocto :-)

Haha, no trust me I try not to. It's just a bad copy/paste from the
Yocto commit log.

>>  define FIRMWARE_IMX_INSTALL_TARGET_CMDS
>> -     mkdir -p $(TARGET_DIR)/lib/firmware
>> +     mkdir -p $(TARGET_DIR)/lib/firmware/imx
>>       for blobdir in $(FIRMWARE_IMX_BLOBS); do \
>>               cp -r $(@D)/firmware/$${blobdir} $(TARGET_DIR)/lib/firmware; \
>>       done
>> +     cp -r $(@D)/firmware/epdc $(TARGET_DIR)/lib/firmware/imx; \
>
> The ; \ is not needed.
>
>> +     mv $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw.nonrestricted \
>> +        $(TARGET_DIR)/lib/firmware/imx/epdc/epdc_ED060XH2C1.fw;
>
> The final is not needed.
>
> Also, this rename is a bit weird, maybe a comment would have been good.

I agree, my guess is that the driver is looking for the .fw file but
the package includes this strange .nonrestricted extension. So I just
copied what was done in the Yocto package.

Regards,
Gary