[Buildroot] [PATCH] quagga: Create /var/run/quagga on sysv

[Matthew Weber]

Peter//Thomas,

On Wed, Dec 21, 2016 at 3:14 AM, Peter Korsgaard <peter at korsgaard.com> wrote:
>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:
>
>  > Hello,
>  > Thanks for this patch!
>
>  > On Tue, 20 Dec 2016 22:07:33 -0600, Matt Weber wrote:
>
>  >> diff --git a/package/quagga/S99quagga b/package/quagga/S99quagga
>  >> new file mode 100644
>  >> index 0000000..e964387
>  >> --- /dev/null
>  >> +++ b/package/quagga/S99quagga
>  >> @@ -0,0 +1,6 @@
>  >> +#!/bin/sh
>  >> +
>  >> +if [ ! -d /var/run/quagga ]; then
>  >> +       mkdir -p /var/run/quagga
>  >> +       chown quagga:quagga /var/run/quagga
>  >> +fi
>
>  > I think we would prefer to have a real init script, that not only
>  > creates /var/run/quagga, but also starts quagga itself. I.e something
>  > that does the same as the systemd unit file.
>
> Yes, agreed. Also notice that the explicit /var/run/quagga check isn't
> needed when you use mkdir -p.

Thanks for the review, we're working on an update.

-- 
Matthew L Weber / Pr Software Engineer
Airborne Information Systems / Security Systems and Software / Secure Platforms
MS 131-100, C Ave NE, Cedar Rapids, IA, 52498, USA
www.rockwellcollins.com

Note: Any Export License Required Information and License Restricted
Third Party Intellectual Property (TPIP) content must be encrypted and
sent to matthew.weber at corp.rockwellcollins.com.