[Buildroot] [PATCH 2/2] tinycbor: fix issue on unnamed union

[Thomas Petazzoni]

Hello,

On Tue, 16 Aug 2016 22:57:58 +0200, Fabrice Fontaine wrote:
> Dear Peter,
> 
> After more investigation, it seems that the uclibc for the blackfin target
> is configured without __UCLIBC_HAS_GLIBC_CUSTOM_STREAMS__
> (./output/host/opt/ext-toolchain/bfin-uclinux/bfin-uclinux/runtime/usr/include/bits/uClibc_config.h).
> Without this option, fopencookie is not available in the toolchain and so
> the implementation of open_memstream function within tinycbor fails so I
> would suggest to disable tinycbor if BR2_bfin target is set.
> 
> If this solution is acceptable, I can provide a patch.

This solution as-is is not acceptable: we now have support for Blackfin
in the internal toolchain backend, in which case uClibc is built with
UCLIBC_HAS_GLIBC_CUSTOM_STREAMS=y.

Therefore, what you want to do is:

	# package uses fopencookie(), not available with this toolchain
	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX

Could you resend a new patch series that takes into account this
aspect, and the other comments made by Peter Korsgaard?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com